Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(n8n Form Node): Support expressions in completion page #11781

Merged
merged 3 commits into from
Nov 20, 2024
Merged

fix(n8n Form Node): Support expressions in completion page #11781

merged 3 commits into from
Nov 20, 2024
+52 −22

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Nov 19, 2024 •
edited by ShireenMissi
Loading

Summary

fix for n8n Form Node failure when Completion Message contains expression

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2022/community-issue-n8n-form-node-failure-when-completion-message-contains
Fixes #11729
Fixes #11749

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Nov 19, 2024
@ShireenMissi ShireenMissi added the tests-needed This PR needs additional tests label Nov 19, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Form/Form.node.ts 82.35% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ShireenMissi ShireenMissi removed the tests-needed This PR needs additional tests label Nov 20, 2024
ShireenMissi
ShireenMissi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@cypress Cypress
Copy link

cypress bot commented Nov 20, 2024

n8n    Run #7997

Run Properties:  status check passed Passed #7997  •  git commit 3c20fea5e4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2022-community-issue-n8n-form-node-failure-when-completion
Run status status check passed Passed #7997
Run duration 05m 21s
Commit git commit 3c20fea5e4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Shireen Missi
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 475
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 1099167 into master Nov 20, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-2022-community-issue-n8n-form-node-failure-when-completion branch November 20, 2024 08:52
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
@janober
Copy link
Member

janober commented Nov 20, 2024

Got released with n8n@1.69.0

@Joffcom Joffcom mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Milestone
No milestone
3 participants
@michael-radency @janober @ShireenMissi